On Sep 9, 2007, at 2:52 PM, Thomas Broyer wrote: > > 2007/9/9, Anne van Kesteren >> >> On 9/9/07, Thomas Broyer wrote: >>> the line after, the python version reads "if entityName[-1] != ';'" >>> while the ruby version reads "if char_stack[-1] ! ";""; could the >>> bug >>> be here? That's the only difference I can see. >> >> That seems like the bug. It's not about the charStack there but >> whether the entityName actually ends with a ";" or not. Still doesn't >> explain why the port doesn't fail the testcases though... Would there >> be some other way to exploit this bug into a testcase as it's not >> unlikely others will make them. (When I wrote the Python code I made >> exactly the same mistake initially.) > > I made some experiments with the python code and wrote a test (rev. > 999). Also fixed the ruby version as explained above although I > couldn't test the fix.
Tested. Works for me. -ryan --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "html5lib-discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/html5lib-discuss?hl=en-GB -~----------~----~----~----~------~----~------~--~---
