DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38279>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38279 ------- Additional Comments From [EMAIL PROTECTED] 2006-02-05 04:41 ------- Overall I think it looks quite good. The code is well designed and clearly documented. Nice work Roland! Only one major thing came to mind as I was looking over the code. This design seems to rely on polling/waiting for handling responses due to HttpHandle.awaitResponse(). My first inclination would be to instead use callbacks to handle the responses, therefore allowing responses to be processed in the order they are ready as opposed to when they are requested. For the current implementation it doesn't really matter as there is only one dispatch thread, but I'm guessing that if we were to add more threads or use NIO we would want truly asynchronous response handling. Another small thing I noticed was the copyright statement lists 1999-2006, for this code it should just be 2006. Mike -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
