Oleg Kalnichevski wrote:
I have completed the first cut at the non-blocking NIO HTTP transport.
Both client and server side implementations are (more or less) feature
complete at this point.
These are the sample apps demonstrating the new API in action
...
Before I go on hacking I would love to get some initial feedback. Please
let me know what you think
I have only had a quick look, I am currently busy with my own proxy.
One thing with the example code that looks suspicious to me is the keep
alive handling both the client and the server contains something like:
if (!this.connStrategy.keepAlive(response, context)) {
conn.close();
}
Sure it is only a few lines of code, but why not say that client and
server always close the connection and then handle persistent
connections on a higher level (by the connection manager or whatever it
is called).
The current code demands that all users of http client does the right
thing with regards to keep alive.
One thing for the wish list that could be nice to have: support for
FileChannel.transferTo and FileChannel.transferFrom. At least on linux
they become sendfile. If you want to build a fast web server it is
needed. The api for transferTo/From is a bit different from read + write
since data is never in user space. Any thoughts?
/robo
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
