[
https://issues.apache.org/jira/browse/HTTPCORE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roland Weber updated HTTPCORE-39:
---------------------------------
Attachment: 2k7-02-06-impl-catalog.txt
Here's my suggestion. Option 3 takes out most of the nastiness:
response.setStatusCode updates the status code and resets the reason phrase to
null. Handlers can use response.setReasonPhrase at will. Only if the reason
phrase is null after the handling, the service will perform a catalog lookup.
I've thrown in some additional JavaDocs, in particular the @throws in
HttpResponse.
cheers,
Roland
> refactor HttpStatus
> -------------------
>
> Key: HTTPCORE-39
> URL: https://issues.apache.org/jira/browse/HTTPCORE-39
> Project: HttpComponents Core
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.0-alpha3
> Reporter: Roland Weber
> Assigned To: Roland Weber
> Priority: Minor
> Fix For: 4.0-alpha4
>
> Attachments: 2k7-02-03-HttpStatus.txt, 2k7-02-04-status-followup.txt,
> 2k7-02-06-impl-catalog.txt
>
>
> The HttpStatus class not only represents a status code with associated
> message, it also has static factory methods for creating objects with
> hard-coded english status messages. Suggested improvements:
> - define HttpStatusFactory in the API
> - move the factory method stuff to impl, for example EnglishHttpStatusFactory
> - reduce HttpStatus class to representation only, final and serializable
> patch to follow when I find the time
> cheers,
> Roland
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
