Bruno Postle wrote:
> On Sat 24-Jan-2009 at 14:24 -0500, Yuval Levy wrote:
>> so the question is: trunk, or new branch?
> 
> The recent pattern (summer of code projects and nona-gpu) has been 
> to work on the new major features in a branch then merge with the 
> trunk once the work has been done


Indeed, and from my perspective it's not a break of the recent pattern.

At some point, the new major feature flows back into trunk, and this is 
where Lukáš's patch stands IMO.

The process as I see it: Branch out. Make changes. Test that they work 
for you and do not break anything big. Submit for quick review on a few 
alternative platforms. If that review is positive, merge into trunk for 
a broader and thorough review. Branch out again for release.

By submitting his patch, Lukáš asked for a review. I confirm on both 
Ubuntu and Windows. Does not break anything. I vote to put it in trunk.

When you mentioned nona-gpu was ready for trunk, I ran it through the 
same review as I did with Lukáš's patch. It built and worked on my Linux 
notebook. I failed on Windows.

 From my perspective, the vigra patch is closer to trunk than the 
nona-gpu branch. But the problem with my Windows build may lay between 
the chair and the keyboard ;-)

Yuv


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~----------~----~----~----~------~----~------~--~---

Reply via email to