I strongly recommend not changing the function ABIs. Instead, provide
a new symbol without the extra argument or document tha the argument is
now ignored.
Failing that, bump the soname and make this a major or at least a minor
release so it's clear that this release has an ABI break. ABI breaks
in patch-level releases are not a good move.
Yours,
Robert Clausecker
Am Samstag, dem 22.07.2023 um 17:33 +0200 schrieb Bruno Postle:
> Thanks, and I am a little ignorant about these details: since no
> known tools actually use these functions, will leaving the soname
> unchanged be a problem for tools that use other parts of the library
> eg. Hugin, nona etc..? My testing seems to be ok.
>
> We could bump the soname, or we could replace these functions with
> no-op stubs to quieten the abi checkers. What do you think?
>
> --
> Bruno
>
> On Sat, 22 Jul 2023, 13:36 Andreas Metzler, wrote:
> > On 2023-07-18 Bruno Postle wrote:
> > > libpano13 is the PanoTools library for panoramic imaging.
> >
> > > A libpano13-2.9.22 rc1 tarball has been uploaded to sourceforge,
> > > this is
> > > a release candidate for testing that may become the final
> > > release:
> >
> > Hello,
> >
> > This breaks the ABI:
> >
> > a) Removed ShowScript and LaunchAndSendScript function
> > b)
> > -PANO13_IMPEX int WriteScript ( char*
> > res, fullPath* scriptFile, int launch );
> > +PANO13_IMPEX int WriteScript ( char*
> > res, fullPath* scriptFile );
> >
> > -PANO13_IMPEX void WriteResults ( char* script,
> > fullPath *sfile, AlignInfo *g, double ds( int i) , int launch);
> > +PANO13_IMPEX void WriteResults ( char* script,
> > fullPath *sfile, AlignInfo *g, double ds( int i) );
> >
> >
> > I have not found any users on codesearch.debian.net but still a
> > soname
> > bump is required. This should do the trick:
> > --- libpano13-2.9.22~rc1+dfsg.orig/CMakeLists.txt
> > +++ libpano13-2.9.22~rc1+dfsg/CMakeLists.txt
> > @@ -286,7 +286,7 @@ if(NOT WIN32)
> > # Create and install shared library on non-windows
> > add_library(pano13 SHARED ${pano13_hdr} ${pano13_src})
> > target_link_libraries(pano13 ${_common_libs})
> > - set_target_properties(pano13 PROPERTIES VERSION "3.0.0"
> > SOVERSION "3")
> > + set_target_properties(pano13 PROPERTIES VERSION "4.0.0"
> > SOVERSION "4")
> > install(TARGETS pano13 LIBRARY COMPONENT libraries)
> > set(_pano_target pano13)
> > #create and install static library
> > @@ -299,7 +299,7 @@ else()
> > ADD_DEFINITIONS(-DPANO13_DLL)
> > add_library(pano13 SHARED ${pano13_hdr} ${pano13_res}
> > ${pano13_src})
> > target_link_libraries(pano13 ${_common_libs})
> > - set_target_properties(pano13 PROPERTIES VERSION "3.0.0"
> > SOVERSION "3")
> > + set_target_properties(pano13 PROPERTIES VERSION "4.0.0"
> > SOVERSION "4")
> > IF(MINGW)
> > set_target_properties(pano13 PROPERTIES PREFIX "")
> > ENDIF()
> >
> > cu Andreas
> --
> A list of frequently asked questions is available at:
> http://wiki.panotools.org/Hugin_FAQ
> ---
> You received this message because you are subscribed to the Google
> Groups "hugin and other free panoramic software" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to hugin-ptx+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/hugin-ptx/CAJV99ZjU4jCd_fbvQC7qY%3DdgXc8pUm311HQ6iw%2BVNidrx%3D1FXQ%40mail.gmail.com
> .
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/8510f4b78507b394ca59026d408ddba6e1cb91db.camel%40gmail.com.
