I will look at the changes.
But that you put all changes into one big patch makes is difficult to test 
or comment on single issues.
But some comments:
* you are fixing the warning for a specific version of a specific compiler. 
Other compiles or even other versions the same compiler will throw warnings 
on different issues. So fixing all warnings for all compilers and all it 
version (especially for a platform independent way) is a lot of work with 
only little benefits.
* Your changes break the ABI again, this is something which we would 
prevent in this release.
* You did also white spaces changes and introduced a mixed indentation 
style.

Thomas

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/7b149cca-a00a-49c4-aa1f-b139d4be7630n%40googlegroups.com.

Reply via email to