On Saturday 23 August 2008 22:28:31 Krzysztof Foltman wrote: > When loading a different drum kit, the mute settings for individual > instruments aren't preserved. Maybe they should? (not a bug, but still > slightly inconvenient) > > What's more, leaving instrument solo in ON position and loading another > (or same) drum kit gives a quite unusual effect: For the instruments > that exist in the new drum kit, mute is off. For "old" instruments, mute > is on. The solo switch remains in ON position. If I press it again, it's > displayed as OFF but acts as if it was in ON state (ie. all other > instruments are muted). If I toggle it once more, it gets back to ON > state but acts as OFF: other instruments are not muted. THAT looks like > a bug to me.
I agree > > I've tried to fix it by remembering the muted state of an instrument > before load_from_placeholder and setting it just after (hydrogen.cpp, > function H2Core::Hydrogen::loadDrumkit()): > > // preserve mute state > bool was_muted = pInstr->is_muted(); > // creo i nuovi layer in base al nuovo strumento > // Moved code from here right into the Instrument class - Jakob > Lund. > pInstr->load_from_placeholder( pNewInstr ); > pInstr->set_muted(was_muted); > > and it *seems* to work (for both solo and mute!), but I'm not sure if > it's a correct solution or if it doesn't cause any problems. The current It seems that it would surely preserve the 'mute' state for the imported instruments, and if Solo works by changing mute states, that should work too. I'm not sure, though, whether this should go in loadDrumkit, or inside the Instrument class itself (in load_from_placeholder perhaps) ? > version doesn't run stable enough on my machine to be able to tell (and > scons is being much too stubborn to believe this version is even > compiling properly here - even after scons -c it insists to use old > cached object files, I've started using scons --no-cache but still can't > be sure what else does it do behind my back). Random crashes on drumkit > reload, on sound playback etc... Damn, that sounds bad... At my place things' been running quite stably, except for the instrument deleting thing (and that weird *** glibc detected *** error that wolke just mentioned). I think they've (Comix + Sebastian) have been updating the scons system -- have you tried checking out a fresh copy and building that? :-) > > Krzysztof > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
