Jakob Lund wrote: > Also, it leaves you with a possible crash when removing instruments / > changing > drumkits while there are notes being played - possibly MIDI notes coming into > Hydrogen from a sequencer app or from a keyboard. Perhaps a 'known bugs' note > should accompany the release of RC1 then. > What about a temporary solution of emptying all queues each time an instrument is getting replaced (of course, with proper locking around it)? It's not nice, but better than crashes. Also, gives you more time to get The Right Solution to work correctly in all cases (from valgrind output it seems that GUI may use the data from just-deleted instruments so it gets even more complicated).
(my friend used to say: debugging programs is hard, debugging multithreaded programs is impossible; he didn't use valgrind though) Doing risky things on a branch is a good practice, especially when a stable release is on a horizon. It's even better if someone else can occasionally check out the current state of the branch and see if it works for him or not - because one person is never able to check all the usage patterns that might potentially lead to a crash or incorrect behavior. I might do that - scons problems aside (rm -rf hydrogen && svn checkout should take care of that, if scons --no-cache won't). Krzysztof ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
