> I ran `codespell` on the `src/java.desktop` directory, and accepted those 
> changes where it indeed discovered real typos.
> 
> I ignored typos in public methods and variables. Maybe they can be fixed 
> later on without much fanfare, if they are in internal classes. Typos in 
> exposed APIs are likely here to stay.
> 
> I will update copyright years using a script before pushing (otherwise like 
> every second change would be a copyright update, making reviewing much 
> harder).
> 
> The long term goal here is to make tooling support for running `codespell`. 
> The trouble with automating this is of course all false positives. But before 
> even trying to solve that issue, all true positives must be fixed. Hence this 
> PR.

Magnus Ihse Bursie has updated the pull request incrementally with two 
additional commits since the last revision:

 - Update src/java.desktop/share/classes/javax/swing/JPopupMenu.java
   
   Co-authored-by: Alexey Ivanov <70774172+aivanov-...@users.noreply.github.com>
 - Update src/java.desktop/share/classes/javax/swing/JMenu.java
   
   Co-authored-by: Alexey Ivanov <70774172+aivanov-...@users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8328/files
  - new: https://git.openjdk.java.net/jdk/pull/8328/files/42656f52..b6025570

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8328&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8328&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8328.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8328/head:pull/8328

PR: https://git.openjdk.java.net/jdk/pull/8328

Reply via email to