On Fri, 17 Jan 2025 23:33:50 GMT, Justin Lu <[email protected]> wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> provide message for test assertion
src/java.base/share/classes/java/util/Currency.java line 469:
> 467:
> 468: // Initialize the set of available currencies if needed
> 469: private static synchronized void initAvailableCurrencies() {
Should we make `available` volatile so we can avoid entering the monitor if the
currencies are initialized?
(Note: We may get Stable Values very soon, at that point SV is a much better
solution)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1920921812
