On Fri, 17 Jan 2025 23:33:50 GMT, Justin Lu <[email protected]> wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> provide message for test assertion
src/java.base/share/classes/java/util/Currency.java line 494:
> 492:
> 493: if (scEntry.cutOverTime == Long.MAX_VALUE
> 494: || System.currentTimeMillis() <
> scEntry.cutOverTime) {
It'd be better to obtain the current time once and compare against the same
value for all entries rather than potentially using different current times for
each comparison.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1922102421
