Hi Ben,
On Thu, 29 May 2008 14:22:46 +0100, Ben Dooks wrote:
> Add a MODULE_ALIAS() statement for the i2c-s3c2410 controller
> to ensure that it can be autoloaded on the S3C2440 systems that
> we support.
>
> Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
>
> Index: linux-2.6.26-rc4-quilt1/drivers/i2c/busses/i2c-s3c2410.c
> ===================================================================
> --- linux-2.6.26-rc4-quilt1.orig/drivers/i2c/busses/i2c-s3c2410.c
> 2008-05-28 11:56:54.000000000 +0100
> +++ linux-2.6.26-rc4-quilt1/drivers/i2c/busses/i2c-s3c2410.c 2008-05-28
> 11:57:12.000000000 +0100
> @@ -947,3 +947,4 @@ MODULE_DESCRIPTION("S3C24XX I2C Bus driv
> MODULE_AUTHOR("Ben Dooks, <[EMAIL PROTECTED]>");
> MODULE_LICENSE("GPL");
> MODULE_ALIAS("platform:s3c2410-i2c");
> +MODULE_ALIAS("platform:s3c2440-i2c");
With the current driver code, that's correct.
Acked-by: Jean Delvare <[EMAIL PROTECTED]>
That being said, I think the approach is wrong. You shouldn't register
two different platform drivers just to be able to differentiate between
device types. You have platform_data for that, it's cleaner and cheaper.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
