On Tue, 01 Jul 2008, Andi Kleen wrote: > Henrique de Moraes Holschuh wrote: > > Change the code of hotkey_init, wan_init and bluetooth_init a bit to make it > > much easier to add some Kconfig-selected debugging code later. > > The later seems to be wrong, the debugging code is already included?
No, that patch just moves some code around and changes the way some conditionals were written so it would be easier to add the debugging code later. It is supposed to change nothing as far as functionality goes. I do have that debugging code, but I didn't see a reason to submit it for mainline yet. But it helps me a whole deal if it is easy to just patch it in when I needed it, so patch 1/7 is something I'd like merged. The debugging code itself is a harness to simulate the thinkpad rfkill firmware, as my T43 doesn't have bluetooth, WWAN or the WLSW rfkill switch and I needed a way to test those codepaths. As I said, it is a separate patch I didn't submit yet (and might decide not to submit at all, unless someone asks for it or I find out it would be helpful to track some sort of bug). I.e. the patch does exactly what the description says :-) But I have nothing against changing that description, I just don't know what to put in there that would be better... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
