On 01/23/09 10:04, Kacheong Poon wrote: > Michael Schuster wrote: >> In the userland components, we currently encode the IP version we're using >> as either AF_INET or AF_INET6 (as defined in sys/socket.h), whereas the >> kernel module (common/inet/ilb/ilb.c) uses IPPROTO_IP and IPPROTO_IPV6 >> (netinet/in.h). > > > We have used this convention since the prototype. It is > always the protocol number of layer 3. Is there a need > to change this usage? If we really want to use "IP version" > instead of protocol number, I guess we should use 4 or 6 > (IPV4_VERSION or IPV6_VERSION).
ah ... I'd missed that one. I think we should use it, since that's precisely what we intend to indicate (unless I missed something else). If you agree, I'll make the necessary changes. Michael -- Michael Schuster http://blogs.sun.com/recursion Recursion, n.: see 'Recursion'
