Kacheong Poon wrote:
> Erik Nordmark wrote:
>
>> If what you want to denote is the version of the IP header then it might
>> be easier for the folks have have to understand, support and evolve the
>> code if you use a #define that is about IP versions.
>> The code point used for the ip6_nxthdr and ip_protocol fields describe
>> something different than a version number.
>>
>> Any two unique numbers would of course work without any problems; the
>> issue is understandability.
>
>
> I think the current usage of protocol number is quite
> understandable and does not cause any confusion.
I'd be very worried if the guy who wrote the code was confused ;-)
Thus I think you need to listen to what others are saying.
When ILB is processing a packet in which field in the packet do you find
IPPROTO_IP? Ditto for IPPROTO_IPV6?
Those values are used when an IPvX header is encapsulated in an IPVY
header, which isn't the case here.
Erik
