On 20/02/09 07:01 AM, Michael Schuster wrote:
> Darren Reed wrote:
>> On 19/02/09 07:24 PM, Michael Schuster wrote:
>>> I wrote:
>>>
>>>> This can be done in several ways; we selected to extend the "ilbadm 
>>>> create-servergroup" subcommand thus:
>>>>
>>>>     ilbadm create-servergroup ... [-n serverID=foo ] ..
>>>
>>> upon reflection, I'd like to modify this such that serverID comes 
>>> under the -s option, just like server, eg.
>>>
>>>     ilbadm create-servergroup -s 
>>> server=10.1.1.1-10.1.1.10,serverID=myservers group1
>>>
>>> the same would also apply to "add-server".
>>
>> In your other email, you had:
>> -s server=192.168.1.1,192.168.1.2
>
> that was a mistake (that comes from doing things from memory). that 
> should have been
>     -s server=192.168.1.1-192.168.1.2
>
>> So I suppose you want to tack "serverID" on the end of that too?
>>
>> Sounds like a mess waiting to happen (so far as code goes.)
>
> indeed, it would :-) thx for catching it.
>
>> btw, it is counterintuitive to have a noun, in the singular,
>> referring to multiple objects (server=IP1,IP2)
>
> we could just as well change that to "servers". (the implementation 
> currently accepts both, but *don't tell* ;-)

That's a bug that would be rejected during code review.

Darren


Reply via email to