FYI: https://github.com/infinispan/infinispan/pull/5257
But we first need to fix 9.0.x branch :D On Mon, Jul 3, 2017 at 10:48 AM Bela Ban <bela...@mailbox.org> wrote: > Hi Thomas, > > has this issue been resolved? Env variables were introduced in 4.0.2 > [1], so you need at least that version of JGroups. > > [1] https://issues.jboss.org/browse/JGRP-2166 > > On 30/06/17 11:40, Thomas SEGISMONT wrote: > > Hi everyone, > > > > Thank you for this great work, the dependency diet and the extra port > > removal are both very useful. The extra port removal is key to enable > > Vert.x clustering in Openshift S2I environments. > > > > I tried the new KUBE_PING (beta1) with vertx-infinispan and it worked > > fine. I have a few questions though. > > > > I couldn't configure it with env variables. Before you ask, yes I > > noticed the name changes ;-) I only had a quick look at JGroups config > > code but it seems it only resolves system properties. Did it work for > > you because you tried with an Infinispan server? > > > > Since I couldn't configure it externally I had to create a custom > > JGroups file. Usually, we recommend [1] Vert.x users to add the > > infinispan-cloud dependency and a system property: > > -Dvertx.jgroups.config=default-configs/default-jgroups-kubernetes.xml > > > > My custom JGroups file is a just a copy of > > default-configs/default-jgroups-kubernetes.xml in which I added the > > masterHost and namespace properties. > > > > Is it still recommended to use the > > default-configs/default-jgroups-kubernetes.xml stack ? Or is any change > > planned after the KUBE_PING changes? > > I wouldn't expect a protocol implementation change to impact a stack > > configuration but they say there are no stupid questions :) > > > > Thank you, > > Thomas > > > > > > [1] > http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3 > > > > 2017-06-15 8:21 GMT+02:00 Sebastian Laskawiec <slask...@redhat.com > > <mailto:slask...@redhat.com>>: > > > > Yep, no problems found!!! > > > > I had also impression that the new implementation is "faster". > > Though I haven't measured it... it just my impression. > > > > Awesome work Bela! > > > > On Thu, Jun 15, 2017 at 7:42 AM Bela Ban <bela...@mailbox.org > > <mailto:bela...@mailbox.org>> wrote: > > > > Thanks, Sebastian! > > > > I assume testing on GKE and minikube/openshift was successful? > > > > > > On 14/06/17 13:15, Sebastian Laskawiec wrote: > > > Hey guys, > > > > > > Just a heads up, I've just created a PR that upgrades > KUBE_PING to > > > 1.0.0.Beta1 [1]. As you probably seen in [2], 1.0.0.Beta1 was > > completely > > > rewritten and might behave slightly differently. > > > > > > Here is a summary of changes: > > > > > > * The latest KUBE_PING doesn't require embedded HTTP server > for > > > discovery. Thus it is no longer required to expose port > > 8888 in Pods. > > > * The number of dependencies has been decreased. Currently > > we only > > > require JGroups and OAuth library. > > > * The new KUBE_PING works only with JGroups 4. There will be > no > > > JGroups 3 support. > > > * Some of the environmental variables were shortened and we > > removed > > > `OPENSHIFT` prefix. So if you use > > `OPENSHIFT_KUBE_PING_NAMESPACE`, > > > you will need to change it to `KUBERNETES_NAMESPACE`. > > Please refer > > > to [3] for more information. > > > > > > I also switched default branch in Kubernetes Ping repository > > to master [4]. > > > > > > Thanks, > > > Sebastian > > > > > > [1] https://github.com/infinispan/infinispan/pull/5201 > > <https://github.com/infinispan/infinispan/pull/5201> > > > [2] > > > http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html > > < > http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html> > > > [3] > > > https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc > > < > https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc > > > > > [4] https://github.com/jgroups-extras/jgroups-kubernetes > > <https://github.com/jgroups-extras/jgroups-kubernetes> > > > -- > > > > > > SEBASTIAN ŁASKAWIEC > > > > > > INFINISPAN DEVELOPER > > > > > > Red Hat EMEA <https://www.redhat.com/> > > > > > > <https://red.ht/sig> > > > > > > > > > > > > _______________________________________________ > > > infinispan-dev mailing list > > > infinispan-dev@lists.jboss.org > > <mailto:infinispan-dev@lists.jboss.org> > > > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > <https://lists.jboss.org/mailman/listinfo/infinispan-dev> > > > > > > > -- > > Bela Ban | http://www.jgroups.org > > > > _______________________________________________ > > infinispan-dev mailing list > > infinispan-dev@lists.jboss.org > > <mailto:infinispan-dev@lists.jboss.org> > > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > <https://lists.jboss.org/mailman/listinfo/infinispan-dev> > > > > -- > > > > SEBASTIAN ŁASKAWIEC > > > > INFINISPAN DEVELOPER > > > > Red Hat EMEA <https://www.redhat.com/> > > > > <https://red.ht/sig> > > > > > > _______________________________________________ > > infinispan-dev mailing list > > infinispan-dev@lists.jboss.org <mailto: > infinispan-dev@lists.jboss.org> > > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > <https://lists.jboss.org/mailman/listinfo/infinispan-dev> > > > > > > > > > > _______________________________________________ > > infinispan-dev mailing list > > infinispan-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > > > -- > Bela Ban | http://www.jgroups.org > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- SEBASTIAN ŁASKAWIEC INFINISPAN DEVELOPER Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig>
_______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev