Also Any and all suggestions for speed improvements would be greatly
appreciated. I have a couple vobs that this script takes 3 days
to run against ;)
Thanks!
donald
On Thu, Sep 07, 2000 at 02:38:54PM -0400, Donald Sharp wrote:
> On Thu, Sep 07, 2000 at 01:59:07PM -0400, Larry Jones wrote:
> > Donald Sharp writes:
> > >
> > > I wrote a tool that will tell you what files are corrupted in the
> > > repository. I am including it as a attachment( wonder If we'll get
> > > that Virus warning )
> >
> > Cool! (And yes, we did.)
> >
> > > Any thoughts would be greatly appreciated.
> >
> > I haven't looked at it in any great detail, but it looks like it does a
> > reasonably through and efficient job, except for one thing:
> >
> > > my $ret_code = system( "cvs -l co -n -p -r $revision $file > /dev/null 2>&1"
>);
> > >
> > > return( $ret_code >> 8 );
> >
> > A corrupt RCS file can easily cause CVS to crash (either deliberately
> > due to an assertion failure or accidentally), so you don't want to
> > ignore the low-order bits of the return code. It's probably sufficient
> > to return $ret_code without any modification.
>
> Yep. I ran into this problem. The reason that I did it this
> way was because it would cause the function to return true for
> success and false for failure. I didn't care *why* it failed.
> Just that it did fail.
>
> Thanks!
>
> donald
> >
> > -Larry Jones
> >
> > He doesn't complain, but his self-righteousness sure gets on my nerves.
> > -- Calvin
