Donald Sharp writes:
> 
> I wrote a tool that will tell you what files are corrupted in the
> repository.  I am including it as a attachment( wonder If we'll get
> that Virus warning )

Cool!  (And yes, we did.)

> Any thoughts would be greatly appreciated.

I haven't looked at it in any great detail, but it looks like it does a
reasonably through and efficient job, except for one thing:

>     my $ret_code = system( "cvs -l co -n -p -r $revision $file > /dev/null 2>&1" );
> 
>     return( $ret_code >> 8 );

A corrupt RCS file can easily cause CVS to crash (either deliberately
due to an assertion failure or accidentally), so you don't want to
ignore the low-order bits of the return code.  It's probably sufficient
to return $ret_code without any modification.

-Larry Jones

He doesn't complain, but his self-righteousness sure gets on my nerves.
-- Calvin

Reply via email to