I agree with both of Brad's comments.
On Thu, Jan 16, 2014 at 11:03 AM, Brad King <[email protected]> wrote: > On 01/16/2014 10:51 AM, Bradley Lowekamp wrote: >> It's not clear from your(s) comments if you are in favor of using >> remote modules for all new modules or not? > > No. AFAIK remote modules are to be used when their maintainers > intentionally want to distribute the module separately from > upstream ITK. I don't think they should be part of the review > process for contributions intended to go upstream. > >> Or if small new contribution like a single class should be added >> as separate module or integrated into the appropriate existing module? > > It should be integrated in an appropriate existing module if it > makes sense and otherwise used to create a new module. That > decision should be part of the review process. In either case > by putting the code right in the source tree for review then > we get Gerrit and CDash@Home to test it. > > -Brad K > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers -- Unpaid intern in BillsBasement at noware dot com _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
