So i do have one request - but its a nit - for the following case, should it be 
a guc_warn instead of a guc_dbg?
(last hunk in this patch)
        "No register capture node found for 0x%04X / 0x%08X\n",
        ce->guc_id.id, ce->lrc.lrca);"

Otherwise LGTM,
Reviewed-by: Alan Previn <alan.previn.teres.ale...@intel.com>

On Thu, 2023-02-02 at 16:11 -0800, john.c.harri...@intel.com wrote:
> From: John Harrison <john.c.harri...@intel.com>
> 
> Update a bunch more debug prints to use the new GT based scheme.
> 
> Signed-off-by: John Harrison <john.c.harri...@intel.com>
> ---
>  .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 51 ++++++++-----------
>  1 file changed, 21 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c 
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> index fc3b994626a4f..5f6e3594dda62 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c
> @@ -15,6 +15,7 @@

alan:snip

Reply via email to