On Wed, Jan 29, 2025 at 04:46:33PM +0200, Jani Nikula wrote:
> The limits get passed around, but are only modified in a few
> places. Constify the pointers elsewhere so it's easier to follow where
> they can be modified.
> 
> Signed-off-by: Jani Nikula <[email protected]>

Reviewed-by: Imre Deak <[email protected]>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c     | 18 +++++++++---------
>  drivers/gpu/drm/i915/display/intel_dp.h     |  2 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c |  6 +++---
>  3 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c 
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index a286e5e31c4d..d367f9c2fa23 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1941,7 +1941,7 @@ static bool is_bw_sufficient_for_dsc_config(u16 
> compressed_bppx16, u32 link_cloc
>  
>  static int dsc_compute_link_config(struct intel_dp *intel_dp,
>                                  struct intel_crtc_state *pipe_config,
> -                                struct link_config_limits *limits,
> +                                const struct link_config_limits *limits,
>                                  u16 compressed_bppx16,
>                                  int timeslots)
>  {
> @@ -2061,7 +2061,7 @@ static int dsc_src_max_compressed_bpp(struct intel_dp 
> *intel_dp)
>  static int
>  icl_dsc_compute_link_config(struct intel_dp *intel_dp,
>                           struct intel_crtc_state *pipe_config,
> -                         struct link_config_limits *limits,
> +                         const struct link_config_limits *limits,
>                           int dsc_max_bpp,
>                           int dsc_min_bpp,
>                           int pipe_bpp,
> @@ -2104,7 +2104,7 @@ static int
>  xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
>                             const struct intel_connector *connector,
>                             struct intel_crtc_state *pipe_config,
> -                           struct link_config_limits *limits,
> +                           const struct link_config_limits *limits,
>                             int dsc_max_bpp,
>                             int dsc_min_bpp,
>                             int pipe_bpp,
> @@ -2153,7 +2153,7 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
>  static int dsc_compute_compressed_bpp(struct intel_dp *intel_dp,
>                                     const struct intel_connector *connector,
>                                     struct intel_crtc_state *pipe_config,
> -                                   struct link_config_limits *limits,
> +                                   const struct link_config_limits *limits,
>                                     int pipe_bpp,
>                                     int timeslots)
>  {
> @@ -2185,7 +2185,7 @@ int intel_dp_dsc_min_src_input_bpc(void)
>  }
>  
>  static
> -bool is_dsc_pipe_bpp_sufficient(struct link_config_limits *limits,
> +bool is_dsc_pipe_bpp_sufficient(const struct link_config_limits *limits,
>                               int pipe_bpp)
>  {
>       return pipe_bpp >= limits->pipe.min_bpp &&
> @@ -2194,7 +2194,7 @@ bool is_dsc_pipe_bpp_sufficient(struct 
> link_config_limits *limits,
>  
>  static
>  int intel_dp_force_dsc_pipe_bpp(struct intel_dp *intel_dp,
> -                             struct link_config_limits *limits)
> +                             const struct link_config_limits *limits)
>  {
>       struct intel_display *display = to_intel_display(intel_dp);
>       int forced_bpp;
> @@ -2220,7 +2220,7 @@ int intel_dp_force_dsc_pipe_bpp(struct intel_dp 
> *intel_dp,
>  static int intel_dp_dsc_compute_pipe_bpp(struct intel_dp *intel_dp,
>                                        struct intel_crtc_state *pipe_config,
>                                        struct drm_connector_state *conn_state,
> -                                      struct link_config_limits *limits,
> +                                      const struct link_config_limits 
> *limits,
>                                        int timeslots)
>  {
>       const struct intel_connector *connector =
> @@ -2270,7 +2270,7 @@ static int intel_dp_dsc_compute_pipe_bpp(struct 
> intel_dp *intel_dp,
>  static int intel_edp_dsc_compute_pipe_bpp(struct intel_dp *intel_dp,
>                                         struct intel_crtc_state *pipe_config,
>                                         struct drm_connector_state 
> *conn_state,
> -                                       struct link_config_limits *limits)
> +                                       const struct link_config_limits 
> *limits)
>  {
>       struct intel_display *display = to_intel_display(intel_dp);
>       struct intel_connector *connector =
> @@ -2335,7 +2335,7 @@ static void intel_dp_fec_compute_config(struct intel_dp 
> *intel_dp,
>  int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
>                               struct intel_crtc_state *pipe_config,
>                               struct drm_connector_state *conn_state,
> -                             struct link_config_limits *limits,
> +                             const struct link_config_limits *limits,
>                               int timeslots,
>                               bool compute_pipe_bpp)
>  {
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.h 
> b/drivers/gpu/drm/i915/display/intel_dp.h
> index ca49f0a05da5..ffc27f8ad226 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp.h
> @@ -75,7 +75,7 @@ int intel_dp_compute_config(struct intel_encoder *encoder,
>  int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
>                               struct intel_crtc_state *pipe_config,
>                               struct drm_connector_state *conn_state,
> -                             struct link_config_limits *limits,
> +                             const struct link_config_limits *limits,
>                               int timeslots,
>                               bool recompute_pipe_bpp);
>  void intel_dp_audio_compute_config(struct intel_encoder *encoder,
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c 
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index d58facf78aa9..2acc26aad6a0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -363,7 +363,7 @@ int intel_dp_mtp_tu_compute_config(struct intel_dp 
> *intel_dp,
>  static int mst_stream_find_vcpi_slots_for_bpp(struct intel_dp *intel_dp,
>                                             struct intel_crtc_state 
> *crtc_state,
>                                             int max_bpp, int min_bpp,
> -                                           struct link_config_limits *limits,
> +                                           const struct link_config_limits 
> *limits,
>                                             struct drm_connector_state 
> *conn_state,
>                                             int step, bool dsc)
>  {
> @@ -388,7 +388,7 @@ static int mst_stream_find_vcpi_slots_for_bpp(struct 
> intel_dp *intel_dp,
>  static int mst_stream_compute_link_config(struct intel_dp *intel_dp,
>                                         struct intel_crtc_state *crtc_state,
>                                         struct drm_connector_state 
> *conn_state,
> -                                       struct link_config_limits *limits)
> +                                       const struct link_config_limits 
> *limits)
>  {
>       /*
>        * FIXME: allocate the BW according to link_bpp, which in the case of
> @@ -404,7 +404,7 @@ static int mst_stream_compute_link_config(struct intel_dp 
> *intel_dp,
>  static int mst_stream_dsc_compute_link_config(struct intel_dp *intel_dp,
>                                             struct intel_crtc_state 
> *crtc_state,
>                                             struct drm_connector_state 
> *conn_state,
> -                                           struct link_config_limits *limits)
> +                                           const struct link_config_limits 
> *limits)
>  {
>       struct intel_display *display = to_intel_display(intel_dp);
>       struct intel_connector *connector = 
> to_intel_connector(conn_state->connector);
> -- 
> 2.39.5
> 

Reply via email to