Re: [PATCH 05/22] drm/i915/vrr: Reorganize intel_vrr_compute_cmrr_timings() a bit

[Nautiyal, Ankit K]

On 10/21/2025 12:20 AM, Ville Syrjala wrote:

From: Ville Syrjälä <ville.syrj...@linux.intel.com>

Move the cmrr.enable assignment next to the mode_flags assignment
to keep things in a bit more logical order in
intel_vrr_compute_cmrr_timings().

Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>

---
  drivers/gpu/drm/i915/display/intel_vrr.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c 
b/drivers/gpu/drm/i915/display/intel_vrr.c
index 510dc199376f..01cb9cfe08e1 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -220,7 +220,6 @@ cmrr_get_vtotal(struct intel_crtc_state *crtc_state, bool 
video_mode_required)
  static
  void intel_vrr_compute_cmrr_timings(struct intel_crtc_state *crtc_state)
  {
-       crtc_state->cmrr.enable = true;
        /*
         * TODO: Compute precise target refresh rate to determine
         * if video_mode_required should be true. Currently set to
@@ -230,6 +229,8 @@ void intel_vrr_compute_cmrr_timings(struct intel_crtc_state 
*crtc_state)
        crtc_state->vrr.vmax = cmrr_get_vtotal(crtc_state, false);
        crtc_state->vrr.vmin = crtc_state->vrr.vmax;
        crtc_state->vrr.flipline = crtc_state->vrr.vmin;
+
+       crtc_state->cmrr.enable = true;
        crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
  }