On Mon, Nov 03, 2025 at 02:18:20PM -0300, Gustavo Sousa wrote: > Bspec states that the new AUX power enable/disable sequences are > associated with the LT PHY. As such, use HAS_LT_PHY() instead of IP > checks in those paths in the driver code. > > While at it, also move the comment that we can't use the power status > flag to the "else" branch, since that comment is not applicable for the > LT PHY. > > Bspec: 68967 > Cc: Matt Roper <[email protected]> > Cc: Suraj Kandpal <[email protected]> > Suggested-by: Matt Roper <[email protected]> > Signed-off-by: Gustavo Sousa <[email protected]>
Reviewed-by: Matt Roper <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_display_power_well.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power_well.c > b/drivers/gpu/drm/i915/display/intel_display_power_well.c > index 1485fc65ab87..33c9540a5d73 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power_well.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power_well.c > @@ -1870,19 +1870,19 @@ static void xelpdp_aux_power_well_enable(struct > intel_display *display, > XELPDP_DP_AUX_CH_CTL_POWER_REQUEST, > XELPDP_DP_AUX_CH_CTL_POWER_REQUEST); > > - /* > - * The power status flag cannot be used to determine whether aux > - * power wells have finished powering up. Instead we're > - * expected to just wait a fixed 600us after raising the request > - * bit. > - */ > - if (DISPLAY_VER(display) >= 35) { > + if (HAS_LT_PHY(display)) { > if (intel_de_wait_for_set(display, > XELPDP_DP_AUX_CH_CTL(display, aux_ch), > XELPDP_DP_AUX_CH_CTL_POWER_STATUS, 2)) > drm_warn(display->drm, > "Timeout waiting for PHY %c AUX channel power > to be up\n", > phy_name(phy)); > } else { > + /* > + * The power status flag cannot be used to determine whether aux > + * power wells have finished powering up. Instead we're > + * expected to just wait a fixed 600us after raising the request > + * bit. > + */ > usleep_range(600, 1200); > } > } > @@ -1897,7 +1897,7 @@ static void xelpdp_aux_power_well_disable(struct > intel_display *display, > XELPDP_DP_AUX_CH_CTL_POWER_REQUEST, > 0); > > - if (DISPLAY_VER(display) >= 35) { > + if (HAS_LT_PHY(display)) { > if (intel_de_wait_for_clear(display, > XELPDP_DP_AUX_CH_CTL(display, aux_ch), > XELPDP_DP_AUX_CH_CTL_POWER_STATUS, > 1)) > drm_warn(display->drm, > > -- > 2.51.0 > -- Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation
