On Thu, 06 Nov 2025, Ville Syrjala <[email protected]> wrote: > From: Ville Syrjälä <[email protected]> > > Get rid of all the custom fast vs. slow intel_de_wait_custom() > timeouts that have started to spread like a cancer recently. > > The eventual aim is to get rid of the fast vs. slow timeout > stuff entirely and switch over to poll_timeout_us()...
Are you planning on still having intel_de_wait_something_something, or do you mean using poll_timeout_us() directly? I think I like the intel_de_* wait helpers, but just a coherent small set, and everything beyond that should use poll_timeout_us() instead of adding obscure helpers for one-off cases. BR, Jani. > > v2: Drop the extraneous timeout debugs to make it simpler to change them > Use the slow timeout in all cases where we have both slow and fast > > Ville Syrjälä (10): > drm/i915/cx0: Print the correct timeout > drm/i915/cx0: Nuke extraneous timeout debugs > drm/i915/ltphy: Nuke extraneous timeout debugs > drm/i915/cx0: Replace XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_US with > XELPDP_PORT_POWERDOWN_UPDATE_TIMEOUT_MS > drm/i915/cx0: Get rid of XELPDP_MSGBUS_TIMEOUT_FAST_US > drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/ > drm/i915/cx0: > s/XELPDP_PORT_RESET_END_TIMEOUT/XELPDP_PORT_RESET_END_TIMEOUT_US/ > drm/i915/ltphy: Nuke bogus weird timeouts > drm/i915/hdcp: Use the default 2 usec fast polling timeout > drm/i915/pmdemand: Use the default 2 usec fast polling timeout > > drivers/gpu/drm/i915/display/intel_cx0_phy.c | 52 +++++++++---------- > .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 7 ++- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > drivers/gpu/drm/i915/display/intel_lt_phy.c | 47 ++++++++--------- > .../gpu/drm/i915/display/intel_lt_phy_regs.h | 7 ++- > drivers/gpu/drm/i915/display/intel_pmdemand.c | 2 +- > 6 files changed, 54 insertions(+), 63 deletions(-) -- Jani Nikula, Intel
