TODO: Grab uncore lock during entire vblank evasion before disabling
interrupts, and check what breaks?

Signed-off-by: Maarten Lankhorst <[email protected]>
---
 drivers/gpu/drm/i915/display/i9xx_wm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c 
b/drivers/gpu/drm/i915/display/i9xx_wm.c
index 167277cd88778..59c18b69ccfa8 100644
--- a/drivers/gpu/drm/i915/display/i9xx_wm.c
+++ b/drivers/gpu/drm/i915/display/i9xx_wm.c
@@ -1864,7 +1864,6 @@ static void vlv_atomic_update_fifo(struct 
intel_atomic_state *state,
 {
        struct intel_display *display = to_intel_display(crtc);
        struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-       struct intel_uncore *uncore = &dev_priv->uncore;
        const struct intel_crtc_state *crtc_state =
                intel_atomic_get_new_crtc_state(state, crtc);
        const struct vlv_fifo_state *fifo_state =
@@ -1893,7 +1892,6 @@ static void vlv_atomic_update_fifo(struct 
intel_atomic_state *state,
         * intel_pipe_update_start() has already disabled interrupts
         * for us, so a plain spin_lock() is sufficient here.
         */
-       spin_lock(&uncore->lock);
 
        switch (crtc->pipe) {
        case PIPE_A:
@@ -1952,8 +1950,6 @@ static void vlv_atomic_update_fifo(struct 
intel_atomic_state *state,
        }
 
        intel_de_read_fw(display, DSPARB(display));
-
-       spin_unlock(&uncore->lock);
 }
 
 #undef VLV_FIFO
-- 
2.51.0

Reply via email to