Hi Maarten, kernel test robot noticed the following build errors:
[auto build test ERROR on drm-i915/for-linux-next] [also build test ERROR on drm-i915/for-linux-next-fixes drm-xe/drm-xe-next drm-tip/drm-tip linus/master v6.19-rc1 next-20251219] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-i915-display-Fix-intel_lpe_audio_irq_handler-for-PREEMPT-RT/20251219-044020 base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next patch link: https://lore.kernel.org/r/20251218163408.97508-20-dev%40lankhorst.se patch subject: [i915-rt v4 19/20] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter config: i386-defconfig (https://download.01.org/0day-ci/archive/20251220/[email protected]/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251220/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/i915_driver.c:75: In file included from drivers/gpu/drm/i915/gem/i915_gem_context.h:9: In file included from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19: In file included from drivers/gpu/drm/i915/gt/intel_context_types.h:17: In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26: >> drivers/gpu/drm/i915/intel_uncore.h:455:11: error: expected ';' at end of >> declaration 455 | u32 upper lower, old_upper, loop = 0; | ^ | ; >> drivers/gpu/drm/i915/intel_uncore.h:456:31: error: use of undeclared >> identifier 'uncoree' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:40: error: use of undeclared >> identifier 'upper_reg' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:458:3: error: use of undeclared >> identifier 'old_upper' 458 | old_upper = upper; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:3: error: use of undeclared >> identifier 'lower' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:40: error: use of undeclared >> identifier 'lower_reg' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:460:40: error: use of undeclared identifier 'upper_reg' 460 | upper = intel_uncore_read_fw(uncore, upper_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:461:20: error: use of undeclared identifier 'old_upper' 461 | } while (upper != old_upper && loop++ < 2); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:461:33: error: use of undeclared >> identifier 'loop' 461 | } while (upper != old_upper && loop++ < 2); | ^ drivers/gpu/drm/i915/intel_uncore.h:463:28: error: use of undeclared identifier 'lower' 463 | return (u64)upper << 32 | lower; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:483:44: error: too many arguments to >> function call, expected single argument 'uncore', have 3 arguments 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: 'intel_uncore_read64_2x32_fw' declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 11 errors generated. -- In file included from drivers/gpu/drm/i915/gem/i915_gem_shmem.c:14: In file included from drivers/gpu/drm/i915/i915_drv.h:40: In file included from drivers/gpu/drm/i915/gem/i915_gem_context_types.h:19: In file included from drivers/gpu/drm/i915/gt/intel_context_types.h:17: In file included from drivers/gpu/drm/i915/gt/intel_engine_types.h:26: >> drivers/gpu/drm/i915/intel_uncore.h:455:11: error: expected ';' at end of >> declaration 455 | u32 upper lower, old_upper, loop = 0; | ^ | ; >> drivers/gpu/drm/i915/intel_uncore.h:456:31: error: use of undeclared >> identifier 'uncoree' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:40: error: use of undeclared >> identifier 'upper_reg' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:458:3: error: use of undeclared >> identifier 'old_upper' 458 | old_upper = upper; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:3: error: use of undeclared >> identifier 'lower' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:40: error: use of undeclared >> identifier 'lower_reg' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:460:40: error: use of undeclared identifier 'upper_reg' 460 | upper = intel_uncore_read_fw(uncore, upper_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:461:20: error: use of undeclared identifier 'old_upper' 461 | } while (upper != old_upper && loop++ < 2); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:461:33: error: use of undeclared >> identifier 'loop' 461 | } while (upper != old_upper && loop++ < 2); | ^ drivers/gpu/drm/i915/intel_uncore.h:463:28: error: use of undeclared identifier 'lower' 463 | return (u64)upper << 32 | lower; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:483:44: error: too many arguments to >> function call, expected single argument 'uncore', have 3 arguments 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: 'intel_uncore_read64_2x32_fw' declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gem/i915_gem_shmem.c:515:34: warning: result of comparison of constant 17592186040320 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] 515 | if (BITS_PER_LONG == 64 && size > MAX_LFS_FILESIZE) | ~~~~ ^ ~~~~~~~~~~~~~~~~ 1 warning and 11 errors generated. -- In file included from drivers/gpu/drm/i915/display/hsw_ips.c:13: In file included from drivers/gpu/drm/i915/display/intel_de.h:12: >> drivers/gpu/drm/i915/intel_uncore.h:455:11: error: expected ';' at end of >> declaration 455 | u32 upper lower, old_upper, loop = 0; | ^ | ; >> drivers/gpu/drm/i915/intel_uncore.h:456:31: error: use of undeclared >> identifier 'uncoree' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:456:40: error: use of undeclared >> identifier 'upper_reg' 456 | upper = intel_uncore_read_fw(uncoree, upper_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:458:3: error: use of undeclared >> identifier 'old_upper' 458 | old_upper = upper; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:3: error: use of undeclared >> identifier 'lower' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:459:40: error: use of undeclared >> identifier 'lower_reg' 459 | lower = intel_uncore_read_fw(uncore, lower_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:460:40: error: use of undeclared identifier 'upper_reg' 460 | upper = intel_uncore_read_fw(uncore, upper_reg); | ^ drivers/gpu/drm/i915/intel_uncore.h:461:20: error: use of undeclared identifier 'old_upper' 461 | } while (upper != old_upper && loop++ < 2); | ^ >> drivers/gpu/drm/i915/intel_uncore.h:461:33: error: use of undeclared >> identifier 'loop' 461 | } while (upper != old_upper && loop++ < 2); | ^ drivers/gpu/drm/i915/intel_uncore.h:463:28: error: use of undeclared identifier 'lower' 463 | return (u64)upper << 32 | lower; | ^ >> drivers/gpu/drm/i915/intel_uncore.h:483:44: error: too many arguments to >> function call, expected single argument 'uncore', have 3 arguments 483 | ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: 'intel_uncore_read64_2x32_fw' declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/i915/display/hsw_ips.c:13: >> drivers/gpu/drm/i915/display/intel_de.h:71:9: error: too many arguments to >> function call, expected single argument 'uncore', have 3 arguments 70 | return intel_uncore_read64_2x32_fw(__to_uncore(display), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 71 | lower_reg, upper_reg); | ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/intel_uncore.h:453:1: note: 'intel_uncore_read64_2x32_fw' declared here 453 | intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 12 errors generated. vim +455 drivers/gpu/drm/i915/intel_uncore.h 451 452 static inline u64 453 intel_uncore_read64_2x32_fw(struct intel_uncore *uncore) 454 { > 455 u32 upper lower, old_upper, loop = 0; > 456 upper = intel_uncore_read_fw(uncoree, upper_reg); 457 do { > 458 old_upper = upper; > 459 lower = intel_uncore_read_fw(uncore, lower_reg); 460 upper = intel_uncore_read_fw(uncore, upper_reg); > 461 } while (upper != old_upper && loop++ < 2); 462 463 return (u64)upper << 32 | lower; 464 } 465 466 static inline u64 467 intel_uncore_read64_2x32(struct intel_uncore *uncore, 468 i915_reg_t lower_reg, i915_reg_t upper_reg) 469 { 470 enum forcewake_domains fw_domains; 471 unsigned long flags; 472 u64 ret; 473 474 fw_domains = intel_uncore_forcewake_for_reg(uncore, lower_reg, 475 FW_REG_READ); 476 477 fw_domains |= intel_uncore_forcewake_for_reg(uncore, upper_reg, 478 FW_REG_READ); 479 480 spin_lock_irqsave(&uncore->lock, flags); 481 intel_uncore_forcewake_get__locked(uncore, fw_domains); 482 > 483 ret = intel_uncore_read64_2x32_fw(uncore, lower_reg, upper_reg); 484 485 intel_uncore_forcewake_put__locked(uncore, fw_domains); 486 spin_unlock_irqrestore(&uncore->lock, flags); 487 488 return ret; 489 } 490 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
