> -----Original Message-----
> From: Kandpal, Suraj <[email protected]>
> Sent: Wednesday, January 14, 2026 10:25 AM
> To: Garg, Nemesa <[email protected]>; [email protected];
> [email protected]
> Cc: Garg, Nemesa <[email protected]>
> Subject: RE: [PATCH v2] drm/i915/display: Disable casf with joiner
>
> > Subject: [PATCH v2] drm/i915/display: Disable casf with joiner
> >
>
> This should be drm/i915/casf since you are doing the changes in intel_casf
>
> Also please make sure you are keep the acronyms in capital letters (*CASF)
> Unless you don't mention it as a function name where it cannot be avoided
>
> > Currently pipe scaling is not supported with the joiner. As casf
> > requires pipe
>
> Ditto.
>
Will do.
> > scaling, fail the atomic commit whenever joiner comes into picture.
> >
> > v2: Replace dmesg_WARN with drm_dbg_kms. [Jani]
> >
> > Signed-off-by: Nemesa Garg <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_casf.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_casf.c
> > b/drivers/gpu/drm/i915/display/intel_casf.c
> > index 95339b496f24..63c2c94a243b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_casf.c
> > +++ b/drivers/gpu/drm/i915/display/intel_casf.c
> > @@ -116,6 +116,12 @@ int intel_casf_compute_config(struct
> > intel_crtc_state
> > *crtc_state)
> > return 0;
> > }
> >
> > + /* CASF with joiner not yet supported in hardware */
>
> Commit message does not match the comment.
> Is pipe scaling not supported in H/w or we don't have the support in S/w yet
>
Currently in software we don't have a support for pipe scaling and joiner
working together.
And CASF (which is based on pipe scaling) with joiner is not yet supported in
hardware as it may require some more things as compare to normal pipe scaling.
Will modify the commit message.
Regards,
Nemesa
> Regards,
> Suraj Kandpal
>
> > + if (crtc_state->joiner_pipes) {
> > + drm_dbg_kms(display->drm, "CASF not supported with
> > joiner\n");
> > + return -EINVAL;
> > + }
> > +
> > crtc_state->hw.casf_params.casf_enable = true;
> >
> > /*
> > --
> > 2.25.1
