> Subject: [PATCH v3] drm/i915/casf: Disable CASF with joiner > > Disable CASF with joiner as it is not yet supported in hardware.
Just " Disable CASF with joiner as hardware does not support it." > > v2: Replace dmesg_WARN with drm_dbg_kms. [Jani] > v3: Modify commit message. [Suraj] > > Signed-off-by: Nemesa Garg <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_casf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_casf.c > b/drivers/gpu/drm/i915/display/intel_casf.c > index 95339b496f24..63c2c94a243b 100644 > --- a/drivers/gpu/drm/i915/display/intel_casf.c > +++ b/drivers/gpu/drm/i915/display/intel_casf.c > @@ -116,6 +116,12 @@ int intel_casf_compute_config(struct > intel_crtc_state *crtc_state) > return 0; > } > > + /* CASF with joiner not yet supported in hardware */ Similarly here no need for the "yet" With that fixed LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > + if (crtc_state->joiner_pipes) { > + drm_dbg_kms(display->drm, "CASF not supported with > joiner\n"); > + return -EINVAL; > + } > + > crtc_state->hw.casf_params.casf_enable = true; > > /* > -- > 2.25.1
