On Thu, 2026-01-15 at 11:09 +0000, Kahola, Mika wrote: > > -----Original Message----- > > From: Hogander, Jouni <[email protected]> > > Sent: Thursday, 15 January 2026 9.01 > > To: [email protected]; [email protected] > > Cc: Hogander, Jouni <[email protected]>; Kahola, Mika > > <[email protected]>; Jani Nikula > > <[email protected]>; Vivi, Rodrigo > > <[email protected]>; [email protected] > > Subject: [PATCH] drm/i915/psr: Don't enable Panel Replay on sink if > > globally disabled > > > > With some panels informing support for Panel Replay we are > > observing problems if having Panel Replay enable bit set on sink > > when > > forced to use PSR instead of Panel Replay. Avoid these problems by > > not setting Panel Replay enable bit in sink when Panel Replay is > > globally disabled during link training. I.e. disabled by module > > parameter. > > > > The enable bit is still set when disabling Panel Replay via debugfs > > interface. Added note comment about this. > > > > Fixes: 68f3a505b367 ("drm/i915/psr: Enable Panel Replay on sink > > always when it's supported") > > Cc: Mika Kahola <[email protected]> > > Cc: Jani Nikula <[email protected]> > > Cc: Rodrigo Vivi <[email protected]> > > Cc: <[email protected]> # v6.15+ > > LGTM, > > Reviewed-by: Mika Kahola <[email protected]>
Thank you Mika for the review. This is now pushed to drm-intel-next. BR, Jouni Högander > > > Signed-off-by: Jouni Högander <[email protected]> > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index 91f4ac86c7ad..62208ffc5101 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -842,7 +842,12 @@ static void intel_psr_enable_sink(struct > > intel_dp *intel_dp, > > > > void intel_psr_panel_replay_enable_sink(struct intel_dp > > *intel_dp) { > > - if (CAN_PANEL_REPLAY(intel_dp)) > > + /* > > + * NOTE: We might want to trigger mode set when > > + * disabling/enabling Panel Replay via debugfs interface > > to > > + * ensure this bit is cleared/set accordingly. > > + */ > > + if (CAN_PANEL_REPLAY(intel_dp) && > > +panel_replay_global_enabled(intel_dp)) > > drm_dp_dpcd_writeb(&intel_dp->aux, > > PANEL_REPLAY_CONFIG, > > DP_PANEL_REPLAY_ENABLE); > > } > > -- > > 2.43.0 >
