RE: [PATCH v1 1/1] drm/i915/display: Implement Wa_16024710867

Thu, 22 Jan 2026 01:28:14 -0800 


> -----Original Message-----
> From: Garg, Nemesa <[email protected]>
> Sent: 22 January 2026 10:27
> To: Golani, Mitulkumar Ajitkumar <[email protected]>;
> [email protected]
> Cc: [email protected]; Golani, Mitulkumar Ajitkumar
> <[email protected]>
> Subject: RE: [PATCH v1 1/1] drm/i915/display: Implement Wa_16024710867
> 
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <[email protected]> On Behalf Of
> > Mitul Golani
> > Sent: Thursday, January 22, 2026 9:42 AM
> > To: [email protected]
> > Cc: [email protected]; Golani, Mitulkumar Ajitkumar
> > <[email protected]>
> > Subject: [PATCH v1 1/1] drm/i915/display: Implement Wa_16024710867
> >
> > Reject PTL+ platforms in intel_ddi_port_sync_transcoders, As port sync
> > feature is deprecated from PTL onwards.
> >
> > Signed-off-by: Mitul Golani <[email protected]>
> > ---
> >  drivers/gpu/drm/i915/display/intel_ddi.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> > b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index d8739e2bb004..be774c6d24e7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -4588,8 +4588,11 @@ intel_ddi_port_sync_transcoders(const struct
> > intel_crtc_state *ref_crtc_state,
> >     /*
> >      * We don't enable port sync on BDW due to missing w/as and
> >      * due to not having adjusted the modeset sequence appropriately.
> > +    *
> > +    * Wa_16024710867
> > +    * "Deprecate port sync support for PTL+"
> >      */
> > -   if (DISPLAY_VER(display) < 9)
> > +   if (DISPLAY_VER(display) < 9 || DISPLAY_VER(display) >= 30)
> >             return 0;
> >
> I think all display WAs are moving into intel_display_wa.c.
> 
> So instead of the DISPLAY_VER(display) >= 30 check here, this should use:
> intel_display_needs_wa_16024710867 ()

Although this came as Workaround but more of this is platform restriction to 
deprecate feature for future platform, also Portsync was not supported in 
display version < 9. 
so I am rewriting entire condition as suggested by suraj in his comments.

Thanks
> 
> Regards,
> 
> Nemesa
> >     if (!intel_crtc_has_type(ref_crtc_state, INTEL_OUTPUT_DP))
> > --
> > 2.48.1























					Reply via email to