> Subject: [PATCH v2 1/1] drm/i915/display: Implement Wa_16024710867 >
Let's keep the subject here as Defeature Port Sync rather than implement WA_ I know it shows up as a WA but actually we are just defeaturing this. Its not some Issue we are working around. > Defeature port sync feature for xe3lpd onwards. > --v1: > - Use xe3lpd naming (Suraj) > - Use IS_DISPLAY_VER (Suraj) > You can add the Bspec link for the register where it says this is being defeature I think its in TRANS_DDI_FUNC2 > Signed-off-by: Mitul Golani <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index d8739e2bb004..a3e6f9a31b20 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4588,8 +4588,11 @@ intel_ddi_port_sync_transcoders(const struct > intel_crtc_state *ref_crtc_state, > /* > * We don't enable port sync on BDW due to missing w/as and > * due to not having adjusted the modeset sequence appropriately. > + * > + * Wa_16024710867 > + * Deprecate port sync support for xe3lpd+ You can remove this comment and just modify the above comment to >From xe3lpd onwards we have defeatured this With that fixed LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > */ > - if (DISPLAY_VER(display) < 9) > + if (!IS_DISPLAY_VER(display, 9, 20)) > return 0; > > if (!intel_crtc_has_type(ref_crtc_state, INTEL_OUTPUT_DP)) > -- > 2.48.1
