[Cc: +Thomas]
Dear Anton,
Thank you for your patch. For the summary, I’d suggest something like:
ice/ptp: Report crosstimestamp in ns
Am 12.05.25 um 09:47 schrieb Anton Nadezhdin:
Set use_nsecs=true as timestamp is reported in ns. Lack of this result
in smaller timestamp error window which case error during phc2sys
ca*u*se
execution on some platforms:
phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument
Previously function convert_art_to_tsc was converting ts to the cycles
instead of ns.
Testing hints (ethX is PF netdev):
phc2sys -s ethX -c CLOCK_REALTIME -O 37 -m
On what system with what hardware?
Does the program output anything?
Fixes: d4bea547ebb57 (ice/ptp: Remove convert_art_to_tsc())
Signed-off-by: Anton Nadezhdin <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
Reviewed-by: Arkadiusz Kubalewski <[email protected]>
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c
b/drivers/net/ethernet/intel/ice/ice_ptp.c
index 1fd1ae03eb90..11ed48a62b53 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.c
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
@@ -2307,6 +2307,7 @@ static int ice_capture_crosststamp(ktime_t *device,
ts = ((u64)ts_hi << 32) | ts_lo;
system->cycles = ts;
system->cs_id = CSID_X86_ART;
+ system->use_nsecs = true;
/* Read Device source clock time */
ts_lo = rd32(hw, cfg->dev_time_l[tmr_idx]);
Kind regards,
Paul
