Agree what it should be fix... There was some general changes in kernel which introduce use_nsecs see: https://lore.kernel.org/r/[email protected] And during removal of convert_art_to_tsc() in a process of converting to new API the use_nsecs in the ICE driver was not set.
-----Original Message----- From: Keller, Jacob E <[email protected]> Sent: Monday, May 12, 2025 11:01 PM To: Paul Menzel <[email protected]>; Nadezhdin, Anton <[email protected]> Cc: [email protected]; [email protected]; Loktionov, Aleksandr <[email protected]>; Kubalewski, Arkadiusz <[email protected]>; Thomas Gleixner <[email protected]> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice/ptp: Fix reporting of crosstimestamp On 5/12/2025 1:10 AM, Paul Menzel wrote: > [Cc: +Thomas] > > Dear Anton, > > > Thank you for your patch. For the summary, I’d suggest something like: > > ice/ptp: Report crosstimestamp in ns > > IMHO this should still be "fix ...". This is only a bug because of the refactor to remove convert_art_to_tsc(). It was always intended to report the cross timestamp in nanoseconds, so a title of "report crosstimestamp in ns" gives the wrong impression. This is fixing a bug, not changing an intended behavior.
