On 8/19/2025 5:19 PM, Loktionov, Aleksandr wrote:
...--- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -5267,6 +5267,11 @@ static void e1000_watchdog_task(struct work_struct *work) &adapter->link_duplex); e1000_print_link_info(adapter); + if (adapter->flags2 & FLAG2_DISABLE_K1) { + adapter->hw.dev_spec.ich8lan.disable_k1 = true; + e1000_reconfigure_k1_params(&adapter->hw); + } +You changed the function header comment to require the PHY sem. Good - but. You already correctly hold the lock in other call sites (e.g., init paths). Are you sure watchdog still consistent?
Hi Aleksandr, Thank you for noticing it. Yes, you are correct, a semaphore should be taken here, I will fix it in v2.
/* check if SmartSpeed worked */ e1000e_check_downshift(hw); if (phy->speed_downgraded) -- 2.34.1
