On 8/20/2025 9:57 AM, Timo Teras wrote:
Thanks for adding this!
However, as a user, I find it inconvenient if the default setting
results in a subtly broken system on a device I just from a store.
Since this affects devices from multiple large vendors, would it be
possible to add some kind of quirk mechanism to automatically enable
this on known "bad" systems. Perhaps something based on the DMI or
other system specific information. Could something like this be
implemented?
At least in my use case I have multiple e1000e using laptops on the
same link partner working, and only one broken device for which I
reported this issue. So at least on my experience the issue relates
to specific system primarily (perhaps also requiring a specific link
partner for the issue to show up).
Unfortunately, there is no visible configuration that allows the
driver to reliably identify problematic systems.
If in the future we find such data, then we can improve the
workaround and make it automatic.
At present, the user-controlled interface is the best we have.
Could you look at:
- drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
- drivers/soundwire/dmi-quirks.c
These use dmi_first_match() to match the DMI information of the system
and then apply quirks based on the matching per-system data.
Having similar mechanism in e1000e should be possible, right?
I am happy to provide the needed DMI information from my system if this
works out.
Timo
Hi Timo,
At the moment, we have no clear knowledge as to which systems may be
affected, and what common characteristics they share.
We are working with vendors to try to narrow it down.
You are most welcome to share DMI information from your system. It can
help with further investigation.
However, maintaining a DMI quirk for every single system for which an
issue has been reported is not feasible. Trying to deduce a pattern from
a handful of data points can lead to it being too broad or too narrow.
Furthermore, it may set up expectations of updating the quirk every time
another user comes and says 'your default setting does not work for me'.
This can quickly escalate out of control, and generally seems like the
wrong approach.
Ultimately, vendors are best positioned to manage this, as they know
which of their systems require this parameter. If a list were to be
maintained, I’d suggest something similar to what Mario proposed for
Dell platforms a few years ago for a different issue:
https://patchwork.ozlabs.org/project/netdev/patch/[email protected]/
For now, I prefer not to delay the current patch, acknowledging that
finding a better solution may take time.
