Hi Emil,

FYI, the error/warning was bisected to this commit, please ignore it if it's 
irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 
dev-queue
head:   e50b34f0f3fb86c9be2f9ad3b7ed483f18b46896
commit: 7c0e8a950dbd30ca46e999cf1d25f3e97a98f174 [7/17] idpf: convert vport 
state to bitmap
config: s390-allmodconfig 
(https://download.01.org/0day-ci/archive/20251004/[email protected]/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 
3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20251004/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/intel/idpf/xdp.c:421:20: error: use of undeclared 
>> identifier '__IDPF_VPORT_UP'; did you mean 'IDPF_VPORT_UP'?
     421 |                 if (np->state == __IDPF_VPORT_UP)
         |                                  ^~~~~~~~~~~~~~~
         |                                  IDPF_VPORT_UP
   drivers/net/ethernet/intel/idpf/idpf.h:138:2: note: 'IDPF_VPORT_UP' declared 
here
     138 |         IDPF_VPORT_UP,
         |         ^
   1 error generated.


vim +421 drivers/net/ethernet/intel/idpf/xdp.c

cba102cd719029 Alexander Lobakin 2025-08-26  407  
705457e7211f22 Michal Kubiak     2025-08-26  408  static int 
idpf_xdp_setup_prog(struct idpf_vport *vport,
705457e7211f22 Michal Kubiak     2025-08-26  409                               
const struct netdev_bpf *xdp)
705457e7211f22 Michal Kubiak     2025-08-26  410  {
705457e7211f22 Michal Kubiak     2025-08-26  411        const struct 
idpf_netdev_priv *np = netdev_priv(vport->netdev);
705457e7211f22 Michal Kubiak     2025-08-26  412        struct bpf_prog *old, 
*prog = xdp->prog;
705457e7211f22 Michal Kubiak     2025-08-26  413        struct 
idpf_vport_config *cfg;
705457e7211f22 Michal Kubiak     2025-08-26  414        int ret;
705457e7211f22 Michal Kubiak     2025-08-26  415  
705457e7211f22 Michal Kubiak     2025-08-26  416        cfg = 
vport->adapter->vport_config[vport->idx];
705457e7211f22 Michal Kubiak     2025-08-26  417  
705457e7211f22 Michal Kubiak     2025-08-26  418        if 
(test_bit(IDPF_REMOVE_IN_PROG, vport->adapter->flags) ||
705457e7211f22 Michal Kubiak     2025-08-26  419            
!test_bit(IDPF_VPORT_REG_NETDEV, cfg->flags) ||
705457e7211f22 Michal Kubiak     2025-08-26  420            !!vport->xdp_prog 
== !!prog) {
705457e7211f22 Michal Kubiak     2025-08-26 @421                if (np->state 
== __IDPF_VPORT_UP)
705457e7211f22 Michal Kubiak     2025-08-26  422                        
idpf_xdp_copy_prog_to_rqs(vport, prog);
705457e7211f22 Michal Kubiak     2025-08-26  423  
705457e7211f22 Michal Kubiak     2025-08-26  424                old = 
xchg(&vport->xdp_prog, prog);
705457e7211f22 Michal Kubiak     2025-08-26  425                if (old)
705457e7211f22 Michal Kubiak     2025-08-26  426                        
bpf_prog_put(old);
705457e7211f22 Michal Kubiak     2025-08-26  427  
705457e7211f22 Michal Kubiak     2025-08-26  428                
cfg->user_config.xdp_prog = prog;
705457e7211f22 Michal Kubiak     2025-08-26  429  
705457e7211f22 Michal Kubiak     2025-08-26  430                return 0;
705457e7211f22 Michal Kubiak     2025-08-26  431        }
705457e7211f22 Michal Kubiak     2025-08-26  432  
705457e7211f22 Michal Kubiak     2025-08-26  433        if (!vport->num_xdp_txq 
&& vport->num_txq == cfg->max_q.max_txq) {
705457e7211f22 Michal Kubiak     2025-08-26  434                
NL_SET_ERR_MSG_MOD(xdp->extack,
705457e7211f22 Michal Kubiak     2025-08-26  435                                
   "No Tx queues available for XDP, please decrease the number of regular SQs");
705457e7211f22 Michal Kubiak     2025-08-26  436                return -ENOSPC;
705457e7211f22 Michal Kubiak     2025-08-26  437        }
705457e7211f22 Michal Kubiak     2025-08-26  438  
705457e7211f22 Michal Kubiak     2025-08-26  439        old = 
cfg->user_config.xdp_prog;
705457e7211f22 Michal Kubiak     2025-08-26  440        
cfg->user_config.xdp_prog = prog;
705457e7211f22 Michal Kubiak     2025-08-26  441  
705457e7211f22 Michal Kubiak     2025-08-26  442        ret = 
idpf_initiate_soft_reset(vport, IDPF_SR_Q_CHANGE);
705457e7211f22 Michal Kubiak     2025-08-26  443        if (ret) {
705457e7211f22 Michal Kubiak     2025-08-26  444                
NL_SET_ERR_MSG_MOD(xdp->extack,
705457e7211f22 Michal Kubiak     2025-08-26  445                                
   "Could not reopen the vport after XDP setup");
705457e7211f22 Michal Kubiak     2025-08-26  446  
705457e7211f22 Michal Kubiak     2025-08-26  447                
cfg->user_config.xdp_prog = old;
705457e7211f22 Michal Kubiak     2025-08-26  448                old = prog;
705457e7211f22 Michal Kubiak     2025-08-26  449        }
705457e7211f22 Michal Kubiak     2025-08-26  450  
705457e7211f22 Michal Kubiak     2025-08-26  451        if (old)
705457e7211f22 Michal Kubiak     2025-08-26  452                
bpf_prog_put(old);
705457e7211f22 Michal Kubiak     2025-08-26  453  
aaa3ac6480baeb Alexander Lobakin 2025-08-26  454        
libeth_xdp_set_redirect(vport->netdev, vport->xdp_prog);
aaa3ac6480baeb Alexander Lobakin 2025-08-26  455  
705457e7211f22 Michal Kubiak     2025-08-26  456        return ret;
705457e7211f22 Michal Kubiak     2025-08-26  457  }
705457e7211f22 Michal Kubiak     2025-08-26  458  

:::::: The code at line 421 was first introduced by commit
:::::: 705457e7211f22c49b410eb25e83cef8a61bd560 idpf: implement XDP_SETUP_PROG 
in ndo_bpf for splitq

:::::: TO: Michal Kubiak <[email protected]>
:::::: CC: Tony Nguyen <[email protected]>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to