> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Alok Tiwari
> Sent: Friday, November 7, 2025 1:40 PM
> To: Kitszel, Przemyslaw <[email protected]>; Lobakin,
> Aleksander <[email protected]>; Nguyen, Anthony L
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; intel-
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
> correct module format string
>
> - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" ->
> "if")
>
> - Correct the NVM erase error message format string from "0x02%x" to
> "0x%02x" so the module value is printed correctly.
>
> Signed-off-by: Alok Tiwari <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_fdir.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> b/drivers/net/ethernet/intel/ice/ice_fdir.c
> index 26b357c0ae15..ec73088ef37b 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw,
> struct ice_fdir_fltr *input,
> * ice_fdir_has_frag - does flow type have 2 ptypes
> * @flow: flow ptype
> *
> - * returns true is there is a fragment packet for this ptype
> + * returns true if there is a fragment packet for this ptype
> */
> bool ice_fdir_has_frag(enum ice_fltr_ptype flow) { diff --git
> a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> index d86db081579f..973a13d3d92a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fw_update.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fw_update.c
> @@ -534,7 +534,7 @@ ice_erase_nvm_module(struct ice_pf *pf, u16
> module, const char *component,
> }
>
> if (completion_retval) {
> - dev_err(dev, "Firmware failed to erase %s (module
> 0x02%x), aq_err %s\n",
> + dev_err(dev, "Firmware failed to erase %s (module
> 0x%02x), aq_err
> +%s\n",
> component, module,
> libie_aq_str((enum
> libie_aq_err)completion_retval));
> NL_SET_ERR_MSG_MOD(extack, "Firmware failed to erase
> flash");
> --
> 2.50.1
Reviewed-by: Aleksandr Loktionov <[email protected]>
