> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Loktionov, Aleksandr
> Sent: Friday, November 7, 2025 5:16 AM
> To: Alok Tiwari <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; Lobakin, Aleksander
> <[email protected]>; Nguyen, Anthony L
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; intel-
> [email protected]; [email protected]
> Cc: [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and 
> correct
> module format string
> 
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <[email protected]> On Behalf
> > Of Alok Tiwari
> > Sent: Friday, November 7, 2025 1:40 PM
> > To: Kitszel, Przemyslaw <[email protected]>; Lobakin,
> > Aleksander <[email protected]>; Nguyen, Anthony L
> > <[email protected]>; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected]; intel-
> > [email protected]; [email protected]
> > Cc: [email protected]; [email protected]
> > Subject: [Intel-wired-lan] [PATCH net-next] ice: fix comment typo and
> > correct module format string
> >
> > - Fix a typo in the ice_fdir_has_frag() kernel-doc comment ("is" ->
> > "if")
> >
> > - Correct the NVM erase error message format string from "0x02%x" to
> >   "0x%02x" so the module value is printed correctly.
> >
> > Signed-off-by: Alok Tiwari <[email protected]>
> > ---
> >  drivers/net/ethernet/intel/ice/ice_fdir.c      | 2 +-
> >  drivers/net/ethernet/intel/ice/ice_fw_update.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > index 26b357c0ae15..ec73088ef37b 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_fdir.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
> > @@ -1121,7 +1121,7 @@ ice_fdir_get_gen_prgm_pkt(struct ice_hw *hw,
> > struct ice_fdir_fltr *input,
> >   * ice_fdir_has_frag - does flow type have 2 ptypes
> >   * @flow: flow ptype
> >   *
> > - * returns true is there is a fragment packet for this ptype
> > + * returns true if there is a fragment packet for this ptype

I know this is a simple typo fix and am fine accepting the patch as-is, but you 
could also clean this kdoc error up by using "Returns:" here to avoid a warning 
from the kernel-doc script.

Thanks,
Jake

Reply via email to