> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Alexander Lobakin
> Sent: Monday, November 24, 2025 6:18 PM
> To: Andrew Lunn <[email protected]>; David S. Miller
> <[email protected]>; Eric Dumazet <[email protected]>; Jakub
> Kicinski <[email protected]>; Paolo Abeni <[email protected]>
> Cc: Kitszel, Przemyslaw <[email protected]>; Nguyen,
> Anthony L <[email protected]>; Slepecki, Jakub
> <[email protected]>; NXNE CNSE OSDT ITP Upstreaming
> <[email protected]>; intel-wired-
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix broken Rx on
> VFs
> 
> From: Alexander Lobakin <[email protected]>
> Date: Mon, 24 Nov 2025 18:07:35 +0100
> 
> Ooops, missed a tag, sorry...
> 
> > Since the tagged commit, ice stopped respecting Rx buffer length
> > passed from VFs.
> > At that point, the buffer length was hardcoded in ice, so VFs still
> > worked up to some point (until, for example, a VF wanted an MTU
> larger
> > than its PF).
> > The next commit 93f53db9f9dc ("ice: switch to Page Pool"), broke Rx
> on
> > VFs completely since ice started accounting per-queue buffer lengths
> > again, but now VF queues always had their length zeroed, as ice was
> > already ignoring what iavf was passing to it.
> >
> > Restore the line that initializes the buffer length on VF queues
> > basing on the virtchnl messages.
> >
> > Fixes: 3a4f419f7509 ("ice: drop page splitting and recycling")
> > Reported-by: Jakub Slepecki <[email protected]>
> 
> Suggested-by: Michal Swiatkowski <[email protected]>
> 
> > Reviewed-by: Tony Nguyen <[email protected]>
> > Signed-off-by: Alexander Lobakin <[email protected]>
> > ---
> > I'd like this to go directly to net-next to quickly unbreak VFs (the
> > related commits are not in the mainline yet).
> Thanks,
> Olek

Reviewed-by: Aleksandr Loktionov <[email protected]>

Reply via email to