> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Aleksandr Loktionov > Sent: 27 March 2026 12:53 > To: [email protected]; Nguyen, Anthony L > <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Cc: [email protected] > Subject: [Intel-wired-lan] [PATCH net] ice: fix null-ptr dereference on > false-positive tx timeout > > From: Michal Kubiak <[email protected]> > > Due to some kernel bugs the Tx timeout event may be false-positive. > For example, the kernel commit 95ecba62e2fd ("net: fix races in > netdev_tx_sent_queue()/dev_watchdog()") fixes race conditions that can also > occur during the ice driver initialization. > > In case of such false-positive Tx timeouts there can be no real Tx > transaction started, so the SKB pointer can be NULL. Therefore, the call > devlink_fmsg_dump_skb() can crash because of NULL-ptr dereference. > > Fix that by checking the SKB pointer before dereferencing it. > > Fixes: 2a82874a3b7b ("ice: add Tx hang devlink health reporter") > Cc: [email protected] > Signed-off-by: Michal Kubiak <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]> > --- > > drivers/net/ethernet/intel/ice/devlink/health.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
