> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Aleksandr Loktionov > Sent: 17 April 2026 12:00 > To: [email protected]; Nguyen, Anthony L > <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Cc: [email protected]; Knitter, Konrad <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net 2/4] ice: fix autoneg disable when > link partner doesn't support AN > > From: Konrad Knitter <[email protected]> > > Disabling autonegotiation was silently ignored when autoneg had not yet > completed (ICE_AQ_AN_COMPLETED was not set), leaving the configuration > unchanged with no error. This could prevent link from forming if the link > partner requires non-autoneg mode. > > Extend the condition to also allow disabling autoneg when the link partner > reports no AN ability (ICE_AQ_LP_AN_ABILITY clear). Gate the > ICE_AQ_LP_AN_ABILITY check on the link being up so that stale or zeroed > an_info when link is down does not produce a false positive. > Introduce the helper ice_autoneg_disable_allowed() to make the check explicit. > > Fixes: f1a4a66d2310 ("ice: fix set pause param autoneg check") > Signed-off-by: Konrad Knitter <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 26 ++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
