On Sun, 22 Jun 2003, Johann Hanne wrote:
> I can't believe it. I posted this patch several times. Everybody but Harrie
> ignored it. I even wrote that I hope it gets into 4.3.3. Nobody except Harrie
> replied. Now it's applied and NOW somebody has to claim it's a huge feature
> patch which should not go in. Sorry, but did you actually have a look at the
> patch? It's NOT a huge feature patch.
Harrie is listed as the maintainer of this code, and thus it's his
responsibility to check them. I did have a look at the patch and all I
saw was the addition of two (huge) functions.
> - It adds the TSRM stuff, but it does it the same way as it's done in the
> other extensions.
That's not a problem of course.
> - It adds some constants.
I don't think something like that belongs in a bugfix release.
> - It adds two trivial new functions, both only setting or returning a global.
150 lines of code is not a trivial function.
> - It moves the code for the SNMP value retrieval into a seperate function. But
> this is more a cleanup than a feature patch...?!
> The last one is the ONLY thing where existing code is modified, and I've
> really tested it extensively. So where's the problem???
>
> You could even see it as a BUGFIX patch. The way SNMP values were returned
> until now was unusable it some situations!
*If* the retrieval was modified, it might be even breaking Backward
Compability, which makes this even a bigger non-no.
Derick
--
"Interpreting what the GPL actually means is a job best left to those
that read the future by examining animal entrails."
-------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
International PHP Magazine http://php-mag.net/
-------------------------------------------------------------------------
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
