Good evening, On Wed, Dec 8, 2021, 6:40 PM Christoph M. Becker <cmbecke...@gmx.de> wrote:
> On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > l > > Thanks for your and your colleague's work! It's highly appreciated. > > Anyhow, a respective PR[1] has been submitted now, and I'm in favor of > bundling libavifinfo. I'm not too concerned regarding the additional > size of the PHP binaries which would result by linking it in, but if > others are, we could still introduce a configuration option (e.g. > `--with-libavifinfo`). > > Thoughts? Objections to bundling libavifinfo at all? > > [1] <https://github.com/php/php-src/pull/7711> > On a general principle, I understood that bundling libs should be avoided. I am not totally sure aviinfo is stable enough to be bundle either way. The format will be widely used in a near future so i would rather allow it if libavinfo js available rather than bundling it. best, Pierre > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > >