2022年7月3日(日) 12:00 Go Kudo <g-k...@colopl.co.jp>:

> Hello internals.
>
> Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16
> 03:00:00 (UTC).
>
> https://wiki.php.net/rfc/random_extension_improvement
>
> Best Regards,
> Go Kudo
>

Hi Internals.

Currently, the renaming of Randomizer::shuffleString() to
Randomizer::shuffleBytes() seems acceptable.

I forgot to note the change regarding arguments when I submitted this RFC.
With this change, the argument was supposed to be changed from `string
$string` to `string $bytes`.

- https://github.com/php/php-src/pull/8094#discussion_r916630626

Is this change acceptable? Or should I keep `string $string`?

Regards,
Go Kudo

Reply via email to