> For example, what about the `$binaryString` argument name?

I would recommend to either keep `$string` (conservative) or rename it
to `$bytes` (consistent with the new function name) [I interpret the
RFCs as the former, but the implementation is currently as the
latter].

About your other mail, I too like the idea to split `getInt(int $min =
UNKNOWN, int $max = UNKNOWN)` into distinct `nextInt()` and
`getInt(int $min, int $max)` [in a subsequent PR, IIUC].

Regards,

--
Guilliam Xavier

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

Reply via email to