Hello Tomas,
when developing a patch like this, it is more readable to do typical min
max notation to ease readability. That is change:
if (91 > i && i > 64) {
To:
if (64 < i && i < 91) {
the real issue here is that if we fix it this way we break other locales.
marcus
Thursday, September 6, 2007, 12:39:37 PM, you wrote:
> I can't add comments on that bug report.
> http://www.topolis.lt/php/#35050
> Here comes the patch. Only strcasecmp results are affected. I suspect that
> PHP scripts and interpreter itself use same strcasecmp function.
>> You are free to send a patch..
>>
>> If you have objections, please add comment to the report marked as "Wont
>> fix" and don't spam the already huge database with one more report about
>> same issue.
>>
>> --Jani
>>
>>
>> On Mon, 2007-09-03 at 14:16 +0300, Tomas Kuliavas wrote:
>>> Hi,
>>>
>>> Maybe somebody could provide good explanation why you can fix the issue
>>> (http://bugs.php.net/bug.php?id=42526). You can't claim that locale
>>> insensitive tolower() breaks things, because your functions are locale
>>> insensitive in some setups.
>>>
>>> Now I can only see that PHP developers close bug reports as "bogus" or
>>> "won't fix" without any good explanation. I think I've already said on
>>> this list once. If you lie in order to prove your point, you lose. You
>>> don't need PHP6 in order to fix it. Fix is possible or I don't see whole
>>> picture.
>>>
>>> --
>>> Tomas
Best regards,
Marcus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
