> when developing a patch like this, it is more readable to do typical > min max notation to ease readability. That is change: > if (91 > i && i > 64) { > To: > if (64 < i && i < 91) { > > the real issue here is that if we fix it this way we break other locales.
How they break? Do you want to support case insensitive 8bit method and class names in other locales? If fix breaks other locales, then you are already breaking them on Windows with _tolower_l() function. My test shows that only strcasecmp is affected. Other PHP case insensitive string functions remain LC_CTYPE aware. -- Tomas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php