> On 17.04.2008 18:50, Tatsuo Ishii wrote:
> > Here are the patches against 5.2 HEAD.
> 
> First of all, please use `diff -u`, not just `diff` - unified diffs are much 
> more readable.

Ok. I'll do it next time.

> > Modified API's are:
> > 
> > 1) pg_lo_create now accepts an optional parameter (large object
> >    id). This corresponds to lo_create() which is new in PostgreSQL 8.1.
> > 
> > 2) new API: pg_lo_import_with_oid. Same as pg_lo_import except that it
> >    accepts large object id. This corresponds to lo_import_with_oid()
> >    which is new in PostgreSQL 8.4 (current).
> 
> Is there a real need for a new function?
> Can't we modify pg_lo_import() to accept one more argument?

There's no techinical reason to add lo_import_with_oid(). I just
wanted to directly map the PostgreSQL API to PHP's API. If integrating
to pg_lo_import() is the PHP's way, I would be happy to update my
patches.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to